Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle ModerationRule and KeywordList with shared folder type #594

Merged
merged 6 commits into from
May 11, 2023

Conversation

scolladon
Copy link
Owner

Explain your changes


Make ModerationRule and KeywordList behave like a Wave metadata type
Rename WaveHander into SharedFolderHandler as those metadata specificities is to share a folder

Does this close any currently open issues?


closes #593

  • Jest test added to check the fix is applied.
  • E2E test added to check the fix is applied.

@github-actions
Copy link

github-actions bot commented May 11, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 6 0 0.1s
✅ COPYPASTE jscpd yes no 2.37s
✅ JAVASCRIPT eslint 69 0 0 7.66s
✅ JAVASCRIPT prettier 69 0 0 3.73s
✅ JSON eslint-plugin-jsonc 19 0 0 2.39s
✅ JSON jsonlint 19 0 0.21s
✅ JSON npm-package-json-lint yes no 0.56s
✅ JSON prettier 19 0 0 0.42s
✅ JSON v8r 19 0 11.12s
✅ MARKDOWN markdownlint 10 0 0 0.79s
✅ MARKDOWN markdown-link-check 10 0 12.07s
✅ MARKDOWN markdown-table-formatter 10 0 0 0.37s
✅ REPOSITORY checkov yes no 13.78s
✅ REPOSITORY gitleaks yes no 0.49s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY secretlint yes no 1.11s
✅ REPOSITORY trivy yes no 5.13s
✅ SPELL cspell 128 0 8.98s
✅ TYPESCRIPT eslint 2 0 0 1.96s
✅ YAML prettier 11 0 0 0.54s
✅ YAML v8r 11 0 16.72s
✅ YAML yamllint 11 0 0.84s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (06ebc30) 100.00% compared to head (c7a388a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #594   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines          898       898           
=========================================
  Hits           898       898           
Impacted Files Coverage Δ
src/metadata/metadataManager.js 100.00% <100.00%> (ø)
src/service/botHandler.js 100.00% <100.00%> (ø)
src/service/sharedFolderHandler.js 100.00% <100.00%> (ø)
src/service/typeHandlerFactory.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeclimate
Copy link

codeclimate bot commented May 11, 2023

Code Climate has analyzed commit c7a388a and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon changed the title fix: how ModerationRule and KeywordList are handled fix: handle ModerationRule and KeywordList with shared folder type May 11, 2023
@scolladon scolladon enabled auto-merge (squash) May 11, 2023 07:10
@scolladon scolladon merged commit 770b1ba into main May 11, 2023
@scolladon scolladon deleted the fix/moderation-rule branch May 11, 2023 07:21
@github-actions
Copy link

Shipped in release v5.18.1.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Deploy Keyword List Component Type
2 participants